DRIVERS-3294 Update $lookup prose test to support 8.2+#1846
Merged
connorsmacd merged 13 commits intomongodb:masterfrom Oct 15, 2025
Merged
DRIVERS-3294 Update $lookup prose test to support 8.2+#1846connorsmacd merged 13 commits intomongodb:masterfrom
$lookup prose test to support 8.2+#1846connorsmacd merged 13 commits intomongodb:masterfrom
Conversation
connorsmacd
requested review from
katcharov and
kevinAlbs
and removed request for
a team
kevinAlbs
approved these changes
Oct 1, 2025
Contributor
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM with minor comments.
mdb-ad
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server 8.2 supports mixing QE and non-CSFLE JSON schema validators (SERVER-100260). This PR updates the
$lookupprose test accordingly.Case 8:
db.csflejoinsdb.qeMONGOCRYPT-793 changes
libmongocrypt's behavior to no longer error when QE and CSFLE schemas are mixed. While it is still an error if the CSFLE schema containsencryptvalidators, the error now comes from the query analysis component with a different message. The test case now specifies different expected error substrings depending on the version of the query analysis component.Case 10:
db.qejoinsdb.non_csfle_schema(new)This tests that a
$lookupwith a both QE and non-CSFLE JSON schema validators completes successfully.C Driver Reference Implementations:
libmongocrypt1.16.0libmongocrypt1.17.0Please complete the following before merging:
clusters).